[testing] fix unsafe uintptr usage to be GC-safe on go1.25 #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thaJeztah
force-pushed
the
fix_go_1.25
branch
3 times, most recently
from
28f87e8 to
130a4a7
Compare
Signed-off-by: Sebastiaan van Stijn <[email protected]>
Bumps [github.com/stretchr/testify](https://github.com/stretchr/testify) from 1.9.0 to 1.11.1. - [Release notes](https://github.com/stretchr/testify/releases) - [Commits](stretchr/testify@v1.9.0...v1.11.1) --- updated-dependencies: - dependency-name: github.com/stretchr/testify dependency-version: 1.11.1 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
Replace uintptr fields with typed pointers so the GC considers them alive. relates to changes in go1.25: https://go.dev/doc/go1.25#faster-slices > Faster slices > > The compiler can now allocate the backing store for slices on the stack > in more situations, which improves performance. This change has the potential > to amplify the effects of incorrect `unsafe.Pointer` usage, see for example > [issue 73199]. In order to track down these problems, the [bisect tool] can > be used to find the allocation causing trouble using the `-compile=variablemake` > flag. All such new stack allocations can also be turned off using > `-gcflags=all=-d=variablemakehash=n`. [issue 73199]: https://go.dev/issue/73199 [bisect tool]: https://pkg.go.dev/golang.org/x/tools/cmd/bisect Assisted-by: OpenAI ChatGPT Signed-off-by: Sebastiaan van Stijn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace uintptr fields with typed pointers so the GC considers them alive.
relates to changes in go1.25: https://go.dev/doc/go1.25#faster-slices
Assisted-by: OpenAI ChatGPT