Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revamp/maintenance pass on of mostly non-tgui UI #16902

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

TiviPlus
Copy link
Member

@TiviPlus TiviPlus commented Jan 13, 2025

About The Pull Request

MUST TM
Performs a bunch of maint on the current UIs and brings us more in line with TG
Notable changes:

  • Completely replaces the skin.dmf inplace with our tweaks retroactively applied to bring us up to par with tg. I was having issues porting shit piecemeal because of this due to >dmf
  • Command bar is now only under the text bar
  • some fonts look different (e.g command maptext font is no longer marginally larger since it would blur)
  • going !! will make your text larger and fatter (ie hi vs hi!!)
  • status bar (the thing showing name of obejcts you hover over) replaced to take up a small corner of the space in the bottom right, and is now toggleable in prefs
  • Fixed chat flickering on 516
  • Added a hotkey help button to the top left dropdown menu that calls a shortcut verb in the preferences tab
  • autofit viewport no longer has an arbitrary 1 second delay outside of when connecting
  • fullscreen has been changed to use tg standard, mangled pos calls were making the entire window tiny on OD so might as well
  • random fixes to view data
  • Due to people not having font packs installed correctly, font usage has been swapped to purely font packs that we supply
    • This means the lobby menu now looks different
    • Since I was there also made ready/unready red and green
    • Runechat also looks a little different (some ports are still missing though) but as far as i can tell its mostly more minor stuff
    • Chat announcements have been redone to use a unitary macro for formatting @Lumipharon pls check

more i may have missed

image
image

Notable PRs:
tgstation/tgstation#65225
tgstation/tgstation#67987
tgstation/tgstation#57448
tgstation/tgstation#57531
tgstation/tgstation#63246
tgstation/tgstation#65295
tgstation/tgstation#76552
tgstation/tgstation#76696
tgstation/tgstation#76397
tgstation/tgstation#76356
tgstation/tgstation#88663

Changelog

🆑
add: Adding !! after your message will now make it bigger and fatter in runechat
add: added a top left dropdown and a preferences button to see keybinds
qol: There is now a fullscreen keybind (F11 by default)
qol: The command bar now only shows under the chat, making the gameplay window larger
qol: The status bar (bar showing the name of what you hover over) now only shows as a small box in the bottom left, making the gameplay and chat windows larger. It can also be turned off in prefs now
fix: fixed the UI being broken on Opendream (probably)
fix: chat will no longer flicker on 516
fix: The game will now only use fonts shipped with the game, due to some players not having all fonts installed/ship correctly. as a result of this the lobby menu, runechat, screen orders, etc may look different
code: Aligned skin.dmf with Tg's skin.dmf to make porting simple
code: Autofit viewport no longer has an arbitrary 1 second delay outside of during the user connecting
/:cl:

@TiviPlus TiviPlus added the Requires Testing PRs stable enough for testing, expecting minor changes. label Jan 13, 2025
@TiviPlus TiviPlus requested a review from spookydonut as a code owner January 13, 2025 20:18
@tgstation-server tgstation-server added Code Improvement Changes for adhering to code standards and codebase maintainability. Fix Fixes an issue with the game. Feature New interesting mechanics with new interesting bugs UI We make things worse, but rounder Quality of Life Minor changes that make the game nicer to play labels Jan 13, 2025
@github-actions github-actions bot added the Merge Conflict Pull request is in a conflicted state with base branch. label Jan 13, 2025
@tgstation-server tgstation-server removed the Merge Conflict Pull request is in a conflicted state with base branch. label Jan 14, 2025
@Lumipharon Lumipharon added the Test Merge Candidate This PR has been reviewed and is ready for testing, unless something changes. label Jan 15, 2025
comfyorange added a commit that referenced this pull request Jan 15, 2025
comfyorange added a commit that referenced this pull request Jan 15, 2025
@GravitronBlue
Copy link
Contributor

GravitronBlue commented Jan 15, 2025

Command bar is now only under the text bar

Would like a preference toggle for this.

Edit:
👎 due to causing broken visuals (lobby butons not visually updating, timer fonts being too large, etc.) at this time.

@Notamaniac
Copy link
Contributor

AI orders are completely broken with this, only showing up as ORDERS UPDATED

@Lumipharon
Copy link
Contributor

Announcement font in particular is really ass and way too big.

@tgstation-server tgstation-server removed the Test Merge Candidate This PR has been reviewed and is ready for testing, unless something changes. label Jan 16, 2025
@Neocloudy
Copy link
Contributor

Neocloudy commented Jan 16, 2025

Command bar is now only under the text bar

Would like a preference toggle for this.

Edit: 👎 due to causing broken visuals (lobby butons not visually updating, timer fonts being too large, etc.) at this time.

even if this were viable (it probably isn't) i don't think we should be adding prefs for things only boomers will dislike

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Improvement Changes for adhering to code standards and codebase maintainability. Feature New interesting mechanics with new interesting bugs Fix Fixes an issue with the game. Quality of Life Minor changes that make the game nicer to play Requires Testing PRs stable enough for testing, expecting minor changes. UI We make things worse, but rounder
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants