Merged
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
benjaminnNgo
commented
Jan 2, 2026
benjaminnNgo
commented
Jan 2, 2026
7 tasks
Jacob-Chmura
approved these changes
Feb 10, 2026
Comment on lines
+331
to
+345
| # Load evaluation sets | ||
| root = Path(PROJ_DIR + 'datasets') / dataset_name.replace('-', '_') | ||
| if DATA_VERSION_DICT.get(dataset_name, 1) > 1: | ||
| version_suffix = f'_v{DATA_VERSION_DICT[dataset_name]}' | ||
| else: | ||
| version_suffix = '' | ||
|
|
||
| ns_fname = root / f'{dataset_name}_{split_mode}_ns{version_suffix}.pkl' | ||
| logger.debug( | ||
| 'Loading %s split (neg_sampler.load_eval_set) for dataset: %s from file: %s', | ||
| split_mode, | ||
| dataset_name, | ||
| ns_fname, | ||
| ) | ||
| neg_sampler.load_eval_set(fname=str(ns_fname), split_mode=split_mode) |
Member
There was a problem hiding this comment.
Nit: We could potentially create a helper to share this logic with TGBNegativeEdgeSamplerHook
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary / Description
Added
TGB-tkgl.EdgeBankperformance matches TGB leader board:Related Issues: #303
Type of Change
Test Evidence
Describe how this PR has been tested.
Questions / Discussion Points
List any areas where you’d like reviewer input or have open questions.