Switch from Setuptools to Meson #237
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[skip ci]
Not that it will be used. Just for correctness.
tfpf
commented
Dec 8, 2025
| source_directory + 'sorted_dict_module.cc', | ||
| source_directory + 'sorted_dict_type.cc', | ||
| source_directory + 'sorted_dict_values_type.cc', | ||
| source_directory + 'sorted_dict_view_type.cc', |
Owner
Author
There was a problem hiding this comment.
Suggestion
It may be possible to use the division operator to concatenate paths.
tfpf
commented
Dec 8, 2025
| cpp_args += ['-O0'] | ||
| else | ||
| cpp_args += ['-flto'] | ||
| link_args += ['-flto'] |
Owner
Author
There was a problem hiding this comment.
Important
Use MSVC on Windows. Looks like it’s using the MinGW compiler which might be incompatible with CPython.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.