Add support for other text formats in the file content filter #470
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use a specialized extractor function if registered for the given format (currently PDF and DOCX). For all other formats use the `extract_txt` function as a fallback. Resolves tfeldmann#464.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
The
filecontentfilter now uses a specialized extractor function if registered for the given format (currently PDF and DOCX). For all other formats theextract_txtfunction is used as a fallback.This allows to use the
filecontentfilter for all plain-text files, regardless of the file extension.Related issue number
Resolves #464.
Checklist