Fix "Jump to Method Definition" #24
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This command fails because of the missing "rubygems" library for the custom Ruby 1.8 interpreter of TextMate 2. The only thing its used for is finding the paths of all installed gems. This makes no sense nowadays anyway, as every supported Rails version requires Bundler, which in turn can list only the gems used in a Rails project. Shelling out and using `bundle show --paths` restores the functionality of this command, adds no additional dependencies and, needing to search fewer directories, is quicker too. Fixes textmate#23
|
Can we merge this, it works fine and also gets rid of rubygems dependency for this command. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This command fails because of the missing "rubygems" library for the custom Ruby 1.8 interpreter of TextMate 2. The only thing its used for is finding the paths of all installed gems. This makes no sense nowadays anyway, as every supported Rails version requires Bundler, which in turn can list only the gems used in a Rails project.
Shelling out and using
bundle show --pathsrestores the functionality of this command, adds no additional dependencies and, needing to search fewer directories, is quicker too.Fixes #23