Merged
Conversation
MichaelDeBoey
requested review from
a team,
MatanBobi,
gnapse and
timdeschryver
timdeschryver
approved these changes
Aug 5, 2025
Member
|
Thanks @MichaelDeBoey! |
Member
Author
|
@MatanBobi I don't think we should remove those if we're not actually dropping support for them |
MichaelDeBoey
force-pushed
the
add-tests-for-node-22-24
branch
from
beb35af to
c85ac99
Compare
Member
I understand this approach and I honestly don't have a strong opinion on that. But I just wanted to mention that probably if I were to see a bug happening in a new feature only for Node 14 and Node 16 right now, I would not invest time on fixing them so I also think that we shouldn't test for that, but as I said, no strong opinion :) |
|
🎉 This PR is included in version 6.7.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.