Conversation
|
I would recommend moving also this dependency to the devDeps and bundling it by marking it as not external in the rollup config |
Closed
MichaelDeBoey
force-pushed
the
MichaelDeBoey-patch-1
branch
from
e48acd0 to
74e285c
Compare
MichaelDeBoey
changed the title
lodash with es-toolkitlodash entirely
This was referenced Aug 5, 2025
wojtekmaj
reviewed
Aug 5, 2025
MichaelDeBoey
force-pushed
the
MichaelDeBoey-patch-1
branch
from
74e285c to
d4ede3e
Compare
MichaelDeBoey
force-pushed
the
MichaelDeBoey-patch-1
branch
from
d4ede3e to
963e0d5
Compare
wojtekmaj
approved these changes
Aug 5, 2025
Contributor
wojtekmaj
left a comment
wojtekmaj
left a comment
There was a problem hiding this comment.
LGTM! thanks for pinging me!
timdeschryver
approved these changes
Aug 5, 2025
gnapse
approved these changes
Aug 5, 2025
Member
Author
|
Seems like I should have made this a |
|
🎉 This PR is included in version 6.7.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lodashis unmaintained, big and hard to tree-shake.es-toolkitis a drop-in replacementAs @mrginglymus mentioned in #677, we could just drop
lodashentirelyI'm sure people from the wider @e18e ecosystem cleanup (like @43081j, @benmccann & @outslept) will be very happy to see these kind of changes as well
CC/ @chyzwar @jiahao-c @JReinhold @manudeli @okinawaa @pvargas @Salinn @TheKnarf @wojtekmaj