docs: Update tsconfig setup instructions in the README#621
Open
docs: Update tsconfig setup instructions in the README#621
Conversation
andykenward
suggested changes
Aug 5, 2024
There was a problem hiding this comment.
Instead of these changes, we should add "./vitest.setup.ts" next to "./jest-setup.ts", to make it a bit more obvious.
It appears that a few users are missing out the setup step for TypeScript when using a *.setup.ts file. Perhaps we should add a reference to it in other sections and also make the below line bold?
If you're using TypeScript, make sure your setup file is a .ts and not a .js to include the necessary types
If you're using TypeScript, make sure your setup file is a .ts and not a .js to include the necessary types
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
Fixes #620
Checklist: