add ByA11yState to ALL_QUERIES_METHODS const

[virenpepper]

Checks

• I have read the contributing guidelines.

Changes

• add accessibility queries to ALL_QUERIES_METHODS so we can successfully target those queries while pattern matching

Context

• prefer-screen-queries was failing for destructured a11y queries
• this fixes that

[Belco90]

Hi @virenpepper! Could you give us more context on this query? Where is it coming from?

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.33%. Comparing base (93a6ab9) to head (b2cfc74).
Report is 23 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #956      +/-   ##
==========================================
+ Coverage   96.23%   96.33%   +0.09%     
==========================================
  Files          44       46       +2     
  Lines        2419     2481      +62     
  Branches     1000     1028      +28     
==========================================
+ Hits         2328     2390      +62     
  Misses         91       91              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[virenpepper]

Hi @virenpepper! Could you give us more context on this query? Where is it coming from?

findByA11yState and queryAllByA11yState are part of the React Native Testing library [1] so when we ran this codemod [2] it didn't catch tests that looked like this ~

describe('test', () => {
      it('prefer-screen-queries does not throw an error here', async () => {
        const { findByA11yState } = render(<TestComponent/>);
       expect(queryAllByA11yState({ disabled: true }).length).toBe(1);
        const test = await findByA11yState({
          selected: true,
        });
      });
    });

but a couple things to callout,

• it seems like this library does not support react-native-testing-library out of the gate, and
• *ByA11yState is deprecated

so the tl;dr is maybe this PR can be closed? we are also facing issues where the prefer-screen-queries rule also fails to catch destructured rerender ie

    const { rerender } = render(<TestComponent />);

unsure how to proceed here, as of now we hacked the local library to catch these gaps

[1] https://callstack.github.io/react-native-testing-library/docs/api/queries#by-accessibility-state
[2] https://github.com/atsikov/eslint-jest-testing-library-codemod

eslint-plugin-testing-library - v6.4.0
ESLint - v9.13.0
Node.js - v20.10.0
package manager - yarn v1.22.19
Operating System - macOS Sequoia version 15.0

[MichaelDeBoey]

@virenpepper As you correctly stated: this plugin (currently) doesn't support @testing-library/react-native.

I'll let @Belco90 decide what to do with this, but imo we should not add this and add full support in 1 go instead

[Belco90]

Hey @virenpepper! Sorry it took me so long to react to this.

I've seen there are several PRs for adding support for React Native in this plugin (this PR, #958, others in the past). Instead of having separated PRs for adding support here and there, we should unify the changes to support RN entirely in one go, similar to what was done in #973.

So we need to create an umbrella issue to gather what's missing in this plugin to fully support RN, then move the current work there, including the RN preset.