feat: allow to wait for log line on either stdout or stderr #795
+36
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for testcontainers-rust ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
DDtKey
reviewed
May 29, 2025
testcontainers/src/core/logs.rs
Outdated
Comment on lines
36
to
42
| pub(super) fn is_stdout(self) -> bool { | ||
| matches!(self, Self::StdOut) | ||
| matches!(self, Self::StdOut | Self::BothStd) | ||
| } | ||
|
|
||
| pub(super) fn is_stderr(self) -> bool { | ||
| matches!(self, Self::StdErr) | ||
| matches!(self, Self::StdErr | Self::BothStd) | ||
| } |
There was a problem hiding this comment.
These methods may confuse a little bit (is_stdout -> true for both)
I think it makes sense to rename them to something like includes_stdout/stderr - AFAIR we use it only for filtering on request level
WDYT?
There was a problem hiding this comment.
Changed in 34762da
DDtKey
reviewed
May 29, 2025
| /// Create a new [`LogWaitStrategy`] that waits for the given message to appear in either | ||
| /// standard output logs or standard error logs. | ||
| /// Shortcut for `LogWaitStrategy::new(LogSource::BothStd, message)`. | ||
| pub fn both_std(message: impl AsRef<[u8]>) -> Self { |
There was a problem hiding this comment.
both seems to be applicable only to the source of log, but here it might be confusing (like "and" semantic - wait for a message in both)
stdout_or_stderr seems straightforward here (or any_std at least)
WDYT?
There was a problem hiding this comment.
Changed in 34762da
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces part of changes proposed in #793.
I am not sure about naming of new methods and LogStrategy, I don't like current but was unable to come up with something better.