Skip to content

Don't log compose version to improve startup performance #1012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 25, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ import { DockerImageClient } from "./image/docker-image-client";
import { ImageClient } from "./image/image-client";
import { DockerNetworkClient } from "./network/docker-network-client";
import { NetworkClient } from "./network/network-client";
import { ComposeInfo, ContainerRuntimeInfo, Info, NodeInfo } from "./types";
import { ContainerRuntimeInfo, Info, NodeInfo } from "./types";

export class ContainerRuntimeClient {
constructor(
Expand Down Expand Up @@ -123,9 +123,7 @@ async function initStrategy(strategy: ContainerRuntimeClientStrategy): Promise<C
labels: dockerodeInfo.Labels ? dockerodeInfo.Labels : [],
};

const composeInfo: ComposeInfo = composeClient.version;

const info: Info = { node: nodeInfo, containerRuntime: containerRuntimeInfo, compose: composeInfo };
const info: Info = { node: nodeInfo, containerRuntime: containerRuntimeInfo };

log.trace(`Container runtime info:\n${JSON.stringify(info, null, 2)}`);
return new ContainerRuntimeClient(info, composeClient, containerClient, imageClient, networkClient);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ import { defaultComposeOptions } from "./default-compose-options";
import { ComposeDownOptions, ComposeOptions } from "./types";

export interface ComposeClient {
version: string;
up(options: ComposeOptions, services?: Array<string>): Promise<void>;
pull(options: ComposeOptions, services?: Array<string>): Promise<void>;
stop(options: ComposeOptions): Promise<void>;
Expand All @@ -13,18 +12,14 @@ export interface ComposeClient {

export async function getComposeClient(environment: NodeJS.ProcessEnv): Promise<ComposeClient> {
try {
const version = (await compose.version()).data.version;
return new DockerComposeClient(version, environment);
return new DockerComposeClient(environment);
} catch (err) {
return new MissingComposeClient("N/A");
return new MissingComposeClient();
}
}

class DockerComposeClient implements ComposeClient {
constructor(
public readonly version: string,
private readonly environment: NodeJS.ProcessEnv
) {}
constructor(private readonly environment: NodeJS.ProcessEnv) {}

async up(options: ComposeOptions, services: Array<string> | undefined): Promise<void> {
try {
Expand Down Expand Up @@ -94,7 +89,7 @@ class DockerComposeClient implements ComposeClient {
}

class MissingComposeClient implements ComposeClient {
constructor(public readonly version: string) {}
constructor() {}

up(): Promise<void> {
throw new Error("Compose is not installed");
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
export type Info = {
node: NodeInfo;
containerRuntime: ContainerRuntimeInfo;
compose: ComposeInfo;
};

export type NodeInfo = {
Expand All @@ -25,6 +24,4 @@ export type ContainerRuntimeInfo = {
labels: string[];
};

export type ComposeInfo = string;

export type HostIp = { address: string; family: number };