-
-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PauseAsync and UnpauseAsync #1315
base: develop
Are you sure you want to change the base?
Add PauseAsync and UnpauseAsync #1315
Conversation
✅ Deploy Preview for testcontainers-dotnet ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. Before I review it, could you please add a test? I'm not sure how we can properly test it, but maybe it's enough to run a simple alpine
container, pause it, and check its state?
Yeah, I was not sure either. Gonna look into a basic test. Where would you want me to put it? testContainers.Tests Unit/Containers/Unix |
* fixed a bug in unpause. We now only unpause when the container is in State.Pause
Just put it into the |
Done |
What does this PR do?
Added Methods to Pause and Unpause an container
Why is it important?
Wanted to change some tests in CoreWCF to Testcontainers. Pause and Unpause is used there. Tho I need those methods to continue the implementation