feat: Improve error reporting when loading the Docker configuration file #1263
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for testcontainers-dotnet ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
0xced
force-pushed
the
improve-docker-config-errors
branch
7 times, most recently
from
f5a5f7a to
1e95bea
Compare
HofmeisterAn
force-pushed
the
develop
branch
from
2e15016 to
49ef7dc
Compare
0xced
force-pushed
the
improve-docker-config-errors
branch
from
1e95bea to
11cf6cc
Compare
0xced
force-pushed
the
improve-docker-config-errors
branch
from
11cf6cc to
a527375
Compare
0xced
force-pushed
the
improve-docker-config-errors
branch
from
a527375 to
beaa485
Compare
0xced
force-pushed
the
improve-docker-config-errors
branch
from
beaa485 to
43b87e5
Compare
0xced
force-pushed
the
improve-docker-config-errors
branch
from
43b87e5 to
6641034
Compare
HofmeisterAn
changed the title
HofmeisterAn
approved these changes
May 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This pull request improves error handling while reading the Docker context configuration file. It throws a new
DockerConfigurationExceptioninstead of silently failing.Also, since
GetCurrentEndpoint()can't returnnullanymore there's no need to try the defaultGetSocketPathFromHomeDesktopDir()andGetSocketPathFromHomeRunDir()socket paths.Why is it important?
Silently returning
nullinstead of throwing proper exceptions makes it harder to diagnose issues.Related issues
How to test this PR
The
DockerConfigTestswere updated and a newThrowsWhenDockerConfigEndpointNotFoundtest was added.