Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes to install tabs #58

Closed
wants to merge 1 commit into from
Closed

Fixes to install tabs #58

wants to merge 1 commit into from

Conversation

Frijol
Copy link
Member

@Frijol Frijol commented Oct 17, 2015

fixes #49, #55

Not totally confident in this one, @flaki can you review?

@Frijol
Copy link
Member Author

Frijol commented Oct 18, 2015

@Student007 curious to get your take as well


`source ~/.bashrc`

`nvm install 0.12.7`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NVM doesn't work on Windows-based systems, so it would be cool to make a remark here for Windows users to just install 0.12.7 straight away.

(PS: there is nvmw and similar tools, but IMO they all are a real pain to use...)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I linked to nvm-windows in the Windows implementation - because it's really hard to find the different versions on Node's site. Is nvm-windows not a good solution?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Student007 curious to get your take as well

@Frijol sorry - I am out of time today - I assume I will not be free next weekdays.

The best way to verify is to use my reference machines - that way you will also see some traps. You need to rewrite/cleanup the vagrant file to execute curl https://raw.githubusercontent.com/creationix/nvm/v0.23.2/install.sh | bash and following steps.
Note: The MacOS X reference machine needs up to 20 hours to download the image. But after done once you can work with it like the Windows- and Linux- VMs.

Hope my hard work at this reference images will be payed by being useful at this point 👍

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have both brew and nvm instructions?

@LinusU
Copy link

LinusU commented Oct 20, 2015

As I said in #55 I don't really like the idea of pushing nvm onto our users. If we really want to push an older version, that is still possible using brew. Brew versions have node 0.12 here.

I really feel that we must fix 4.x support before releasing thought.

@Frijol
Copy link
Member Author

Frijol commented Oct 27, 2015

We have Node 4 out & don't need this anymore

@Frijol Frijol closed this Oct 27, 2015
@Frijol Frijol deleted the kb-install branch October 27, 2015 12:14
@flaki
Copy link
Contributor

flaki commented Oct 27, 2015

This is excellent news! 💝

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

document need to use Node below 4.x
5 participants