1.21.1 update #271
1.21.1 update #271
Conversation
broke up ui texture atlases into singular sprite textures where needed. Fixed several issues regarding changes to codecs in 1.21.1. Changed the quest description markdown to rely mainly on HTML-like tags. Fixed neoforge module
common/src/main/java/earth/terrarium/heracles/api/client/WidgetUtils.java
Outdated
Show resolved
Hide resolved
.../main/java/earth/terrarium/heracles/api/client/settings/tasks/BlockInteractTaskSettings.java
Outdated
Show resolved
Hide resolved
common/src/main/java/earth/terrarium/heracles/client/screens/mousemode/MouseModeButton.java
Outdated
Show resolved
Hide resolved
common/src/main/java/earth/terrarium/heracles/client/screens/quests/SelectQuestWidget.java
Outdated
Show resolved
Hide resolved
common/src/main/java/earth/terrarium/heracles/client/screens/quests/SelectQuestWidget.java
Outdated
Show resolved
Hide resolved
...c/main/java/earth/terrarium/heracles/client/screens/quest/editing/QuestMultiLineEditBox.java
Outdated
Show resolved
Hide resolved
...c/main/java/earth/terrarium/heracles/client/screens/quest/editing/QuestMultiLineEditBox.java
Outdated
Show resolved
Hide resolved
common/src/main/java/earth/terrarium/heracles/client/screens/quest/QuestTagProvider.java
Show resolved
Hide resolved
common/src/main/java/earth/terrarium/heracles/client/screens/quest/HeadingWidget.java
Outdated
Show resolved
Hide resolved
common/src/main/java/earth/terrarium/heracles/api/tasks/defaults/KillEntityQuestTask.java
Outdated
Show resolved
Hide resolved
common/src/main/java/earth/terrarium/heracles/mixins/client/ClientLevelMixin.java
Outdated
Show resolved
Hide resolved
…stants and added a id() helper to Heracles.java. Move usages of new NbtPredicate(new CompoundTag()) to a static utility in CustomizableQuestElement.java. Changed currentType field of MouseButtonMode to use an enum instead of a string. Changed a UI element in SelectQuestWidget to render using blitSprite() Fixed QuestMultiLineEditBox formatting notation Added missing @OverRide to QuestTagProvider Changed switch statements in HeadingWidget and WidgetUtils to use enhanced switch statements and switch based off enum value rather than ordinal Reverted unneeded change in ClientLevelMixin
common/src/main/java/earth/terrarium/heracles/api/client/WidgetUtils.java
Outdated
Show resolved
Hide resolved
…summary_background_locked.png
|
On a fresh install with just this mod that I built from the latest commit cf8b350 (and latest Resourceful Lib), I consistently encounter a crash when trying to add a task with type "Block Interaction". The error shows itself ingame as Here are the full logs: https://mclo.gs/H9k1VkC |
you likely didn't populate the title field. leaving it blank will crash you. This was the case in previous versions as well |
ThatGravyBoat
left a comment
ThatGravyBoat
left a comment
There was a problem hiding this comment.
Most of the optionalFieldOfs that were changed to lenient should be changed back to normal optionalFieldOf and if any of the fields being switched back cause it to fail to encode or decode that should be looked into let me know if you need help with those
| ItemStackCodec.CODEC.fieldOf("item").forGetter(ItemReward::stack) | ||
| Codec.STRING.lenientOptionalFieldOf("title", "").forGetter(ItemReward::title), | ||
| QuestIcons.CODEC.lenientOptionalFieldOf("icon", ItemQuestIcon.AIR).forGetter(ItemReward::icon), | ||
| ItemStackCodec.CODEC.lenientOptionalFieldOf("item", Items.AIR.getDefaultInstance()).forGetter(ItemReward::stack) |
There was a problem hiding this comment.
this wasnt optional before
Can this be changed in the PR to silently fallback to a blank title as to not throw if not supplied |
…ling back to an empty string in order to prevent crashes when a title is not provided.
4 participants
Broke up UI texture atlases into singular sprite textures where needed.
Fixed several issues regarding changes to codecs in 1.21.1.
Changed the quest description markdown to rely mainly on HTML-like tags.
Fixed Neoforge module.