Fix: Prevent Valkey instance replacement due to desired_auto_created_… #311
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: Prevent Valkey instance replacement due to desired_auto_created_endpoints field
Problem
Fixes #304 - Valkey instances were being forced to recreate on every Terraform plan/apply due to
desired_auto_created_endpointsfield changing tonull. This was caused by a mismatch between the Terraform configuration usingdesired_psc_auto_connectionsand the actual API response.Solution
desired_psc_auto_connectionstodesired_auto_created_endpointsto match the current Google Cloud Memorystore APIdiscovery_endpoints,psc_connections,psc_auto_connection) and consolidated endpoint informationChanges Made
modules/valkey/main.tf: Updated endpoint configuration field namemodules/valkey/outputs.tf: Removed deprecated outputs, simplified endpoint outputmodules/valkey/README.md: Updated output documentationmodules/valkey/metadata.yaml: Removed deprecated output definitionsexamples/valkey/main.tf: Updated module version to 15.0Testing
Related Issues
Closes #304
Notes
This change aligns the Terraform configuration with the current Google Cloud Memorystore for Valkey API, ensuring stable deployments without forced replacements.