Skip to content

Conversation

@sANGINI2004
Copy link
Contributor

Context:
While exploring the codebase for better understanding, I noticed that the enable_api module was present in both the main.tf file of the examples folder and the modules folder. After confirming with abhiwa@, we concluded that this duplication is redundant.

Rationale:

  1. The examples folder is intended to provide a working demonstration of the resources and code, serving as a practical reference for users.
  2. Including enable_api in this context adds unnecessary complexity and goes against the purpose of examples.

Impact:

  1. Improves clarity for users referring to the examples.
  2. Aligns with best practices by maintaining separation of concerns between examples and modules.

Solution:
Removed the enable_api module from the main.tf in the examples folder.

@sANGINI2004 sANGINI2004 requested review from a team, ayushmjain, imrannayer and q2w as code owners June 11, 2025 06:20
@imrannayer
Copy link
Collaborator

@sANGINI2004 in example we are explicitly calling enable APIs cod enable_apis variable is passed as false in the module call. Module will not enable API. Normally we try to keep enable APIs etc outside of module since majority of the customers enable them as part of project factory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants