Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Update AWS EBS CSI Driver IAM Policy #22

Merged
merged 1 commit into from
Oct 21, 2024
Merged

feat: Update AWS EBS CSI Driver IAM Policy #22

merged 1 commit into from
Oct 21, 2024

Conversation

calvinbui
Copy link
Contributor

@calvinbui calvinbui commented Oct 20, 2024 •
edited
Loading

Description

Update to the EBS CSI Driver IAM Policy

Motivation and Context

See details at kubernetes-sigs/aws-ebs-csi-driver#2190

Copied changes from kubernetes-sigs/aws-ebs-csi-driver#2163

Breaking Changes

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@calvinbui calvinbui changed the title feat: update aws ebs csi driver iam permissions feat: Update AWS EBS CSI Driver IAM Policy Oct 20, 2024
bryantbiggs
bryantbiggs approved these changes Oct 21, 2024
View reviewed changes
Copy link
Member

@bryantbiggs bryantbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you - would you mind making the same change here as well https://github.com/terraform-aws-modules/terraform-aws-eks-pod-identity

@bryantbiggs bryantbiggs merged commit 18e6434 into terraform-aws-modules:master Oct 21, 2024
6 of 8 checks passed
antonbabenko pushed a commit that referenced this pull request Oct 21, 2024
@semantic-release-bot
chore(release): version 1.6.0 [skip ci]
9c294ba 
## [1.6.0](v1.5.0...v1.6.0) (2024-10-21)

### Features

* Update AWS EBS CSI Driver IAM Policy ([#22](#22)) ([18e6434](18e6434))

### Bug Fixes

* Update CI workflow versions to latest ([#21](#21)) ([2f8cf45](2f8cf45))
@antonbabenko
Copy link
Member

This PR is included in version 1.6.0 🎉

@calvinbui
Copy link
Contributor Author

thank you - would you mind making the same change here as well https://github.com/terraform-aws-modules/terraform-aws-eks-pod-identity

do you mean https://github.com/terraform-aws-modules/terraform-aws-iam/tree/master/modules/iam-role-for-service-accounts-eks ?

@calvinbui calvinbui deleted the patch-1 branch October 21, 2024 23:09
@bryantbiggs
Copy link
Member

Oh whoops - got them backwards 😅

Yes, that one

@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bryantbiggs bryantbiggs bryantbiggs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@calvinbui @antonbabenko @bryantbiggs