Repository navigation
Add bananasplit as an alias for the banana command - #47
Merged
Merged
Conversation
The npm package registers both bins. install.sh links bananasplit to the binary; install.ps1 writes a bananasplit.cmd shim, which upgrade carries over from its staging directory. Uninstall removes the alias with the binary.
 [Medium impact] The PR appears safe to merge; both previous findings are fixed. SummaryAdds
Both previous findings are fixed. No new actionable issues were found. Reviews (2) · Last reviewed commit: "Only uninstall a bananasplit alias the i..." · Reviewed by Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
…s on PRs uninstall now checks that bananasplit is a symlink to this binary, or that bananasplit.cmd holds exactly the installer's shim, before removing it. The release workflow also runs on pull requests that touch the installers, update.ts or uninstall.ts, with the version check and publish jobs limited to tag pushes. The Windows installer test checks --help's exit code and output instead of relying on Select-String, which passes on no match. AGENTS.md documents how each install path provides the alias.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lets the CLI run as
bananasplitas well asbanana.package.jsonregisters a secondbananasplitbin.bananasplit -> bananasymlink next to the binary.banana upgradere-runs the installer, so existing installs get the alias on their next upgrade.bananasplit.cmdshim. Symlinks need elevation, and a hard link would point at the old binary after an upgrade, because upgrade replacesbanana.exe. The Windows upgrade path insrc/update.tsnow moves the shim out of the staging dir too..cmdon Windows).bananasplit --help.Tested:
bun test(305 pass) andbun run typecheck. I also built a compiled binary and ran it through the symlink.--helpworks, andexecPathresolves to the realbananafile, soupgradeanduninstallact on the right file. The Windows shim has not been run on Windows; the release workflow's installer job will be the first to exercise it.