Port packages to TQL2 #58
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raxyte
force-pushed
the
tql2-packages
branch
from
e08c013 to
bd49332
Compare
raxyte
force-pushed
the
tql2-packages
branch
from
bd49332 to
eed6ff2
Compare
raxyte
force-pushed
the
tql2-packages
branch
from
eed6ff2 to
e1046b9
Compare
mavam
reviewed
Dec 25, 2024
mavam
approved these changes
Dec 25, 2024
slack/package.yaml
Outdated
| select text=line | ||
| batch 1 | ||
| write_json | ||
| save_http "{{ inputs.webhook-url }}", method="POST" |
There was a problem hiding this comment.
I've changed this but I'm not sure this is a win. When reading the pipeline, the write_json now needs to specified out of line, after the URL.
There was a problem hiding this comment.
IIRC it should work without write_json, as HTTP has JSON as its default format.
raxyte
force-pushed
the
tql2-packages
branch
from
e1046b9 to
56665df
Compare
raxyte
force-pushed
the
tql2-packages
branch
from
56665df to
656e053
Compare
raxyte
commented
Dec 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.