Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MapHeightNodeShader: rename vUv to vMapUv (three >= r151) #93

Merged
merged 1 commit into from
Feb 3, 2025

Conversation

Avnerus
Copy link
Contributor

@Avnerus Avnerus commented Jan 31, 2025

Hi,

Thank you for this library!
I tried using HEIGHT_SHADER with threejs r164 and got an error that vUV is undeclared.
I checked around and found that in r151 vUV was renamed to vMapUv.
This PR fixes the error for me.

/Avner

Copy link

changeset-bot bot commented Jan 31, 2025

⚠️ No Changeset found

Latest commit: 4d8e8b5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@tentone
Copy link
Owner

tentone commented Feb 3, 2025

Thanks a lot! LGTM

Merged!

@tentone tentone merged commit 9112ccf into tentone:master Feb 3, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants