Skip to content

1. Ignore SentencePiece::BYTE during encoding instead of throwing error #1436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

1. Ignore SentencePiece::BYTE during encoding instead of throwing error #1436

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions tensorflow_text/core/kernels/sentencepiece/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ licenses(["notice"])

# Visibility rules
package(default_visibility = [
"//java/com/google/android/apps/pixel/psi:__subpackages__",
"//visibility:public",
])

Expand Down
4 changes: 4 additions & 0 deletions tensorflow_text/core/kernels/sentencepiece/model_converter.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,9 @@ DecodePrecompiledCharsmap(
const ::sentencepiece::NormalizerSpec& normalizer_spec) {
// This function "undoes" encoding done by
// sentencepiece::normalizer::Normalizer::EncodePrecompiledCharsMap.
if (normalizer_spec.precompiled_charsmap().empty()) {
return std::make_tuple(std::vector<uint32_t>(), std::vector<int8_t>());
}
const char* precompiled_map = normalizer_spec.precompiled_charsmap().data();
const uint32_t trie_size =
*reinterpret_cast<const uint32_t*>(precompiled_map);
Expand Down Expand Up @@ -89,6 +92,7 @@ absl::StatusOr<std::string> ConvertSentencepieceModelToFlatBuffer(
break;
case ::sentencepiece::ModelProto::SentencePiece::UNKNOWN:
case ::sentencepiece::ModelProto::SentencePiece::CONTROL:
case ::sentencepiece::ModelProto::SentencePiece::BYTE:
// Ignore unknown and control codes.
break;
default:
Expand Down