rust: remove some ..Default::default()s
#4424
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: In #4399, we decided to recommend `..Default::default()` on struct initializers for protos whose source of truth is not in our repo. This patch removes trivial `..Default::default()`s from struct initializers for `tensorboard.data` protos, which *do* live in our repo. We still use it sometimes: e.g., some requests have a `run_tag_filter` field that we don’t always care to set. This patch will make it harder to add new fields to these protos, but makes the code a bit easier to read in the meantime. Test Plan: Compilation suffices; unit tests are a nice sanity check. wchargin-branch: rust-remove-default-frus wchargin-source: 8b007d8f650840dbf05c459a3414d9dd421170a8
wchargin-branch: rust-remove-default-frus wchargin-source: a9aaeae06cd94d157a995ebfc4c87c8bc45fddc8
nfelt
approved these changes
Dec 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
In #4399, we decided to recommend
..Default::default()on structinitializers for protos whose source of truth is not in our repo. This
patch removes trivial
..Default::default()s from struct initializersfor
tensorboard.dataprotos, which do live in our repo. We still useit sometimes: e.g., some requests have a
run_tag_filterfield that wedon’t always care to set.
This patch will make it harder to add new fields to these protos, but
makes the code a bit easier to read in the meantime.
Test Plan:
Compilation suffices; unit tests are a nice sanity check.
wchargin-branch: rust-remove-default-frus