Consolidate migration folder in OSS (NEW) #7100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zigeH
changed the title
zigeH
commented
Jan 16, 2025
| if !isNotFoundServiceError(err) { | ||
| a.logger.Error("force-replication failed to generate replication task", tag.WorkflowNamespaceID(request.NamespaceID), tag.WorkflowID(we.WorkflowId), tag.WorkflowRunID(we.RunId), tag.Error(err)) | ||
| var executionCandidates []definition.WorkflowKey | ||
| if request.EnableParentInfo { |
There was a problem hiding this comment.
Based on our previous discussion on the old pr, we do not plan to expose the enablePatentInfo here. I plan to remove line 504 and all related tests. Let me know if my understanding is correct
[Consolidate migration folder in OSS](#6893 (comment))
@yux0 @hehaifengcn
There was a problem hiding this comment.
can we not move code related to enablePatentInfo over to oss? either remove it from saas-temporal first or do it in this PR.
There was a problem hiding this comment.
Sg. removed the enablePatentInfo and related tests
hehaifengcn
approved these changes
Jan 21, 2025
yux0
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1, Consolidate force replication, handover wf and catchup wf in OSS with control plane.
2, We copied all 7 files from cp and remove the prefix saas.
What changed?
Why?
How did you test it?
Potential risks
Documentation
Is hotfix candidate?