Fix type assertion panic (#475)

temporalio · Jun 25, 2020 · 679c91e · 679c91e
1 parent 8d3896d
commit 679c91e
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/service/history/historyEngine.go b/service/history/historyEngine.go
@@ -723,8 +723,8 @@ func (e *historyEngineImpl) updateEntityNotExistsErrorOnPassiveCluster(err error
 		if namespaceCacheErr != nil {
 			return err // if could not access namespace cache simply return original error
 		}
-		namespaceNotActiveErr := namespaceCache.GetNamespaceNotActiveErr().(*serviceerror.NamespaceNotActive)
-		if namespaceNotActiveErr != nil {
+
+		if namespaceNotActiveErr, ok := namespaceCache.GetNamespaceNotActiveErr().(*serviceerror.NamespaceNotActive); ok && namespaceNotActiveErr != nil {
 			updatedErr := serviceerror.NewNotFound("Workflow execution not found in non-active cluster")
 			updatedErr.ActiveCluster = namespaceNotActiveErr.ActiveCluster
 			updatedErr.CurrentCluster = namespaceNotActiveErr.CurrentCluster