Expose Core console log format - #2314
Draft
Sushisource wants to merge 2 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Added
telemetryOptions.logging.console.formatso applications can select compact, pretty, or newline-delimited JSON output for Core logs written to the console. The native bridge validates and maps the value to Core. The Core bump also updates bridge construction for newly non-exhaustive Core option types.Why?
Applications that ingest logs as structured data need Core to emit JSON directly instead of human-oriented text with ANSI formatting.
Checklist
pnpm --filter @temporalio/core-bridge lint:checkpnpm --filter @temporalio/test buildpnpm --filter @temporalio/test exec ava ./lib/test-bridge.js --match='Missing/invalid properties in config throws appropriately'