Refactor multi-codec integration test harness - #2308
Draft
THardy98 wants to merge 7 commits into
Draft
Conversation
THardy98
force-pushed
the
agent/local-server-test-marker
branch
from
August 12, 2026 17:49
a2d97c5 to
a9649d3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
This replaces the multi-codec integration helper's hidden
Promise.allfan-out with explicit AVA cases. Each test declaration now produces independently reported[default]and[byte-skewer]cases, and each case receives one helper object whose client operations and Worker factory share a UUID-scoped task queue and the selected data converter.The affected tests no longer reconstruct helpers or pass the AVA context into a separate Worker factory. The harness also cleans up partially created environments, attempts every environment teardown, and avoids running teardown when context creation failed. With the codec variants isolated, the three integration split suites are restored to the Cloud candidate set; the custom-search-attributes suite remains Cloud-pending for its separate provisioning requirement.
Why?
The Cloud run on #2281 exposed a routing collision: the default and byte-skewer variants ran concurrently on the same title-derived task queue, allowing a Worker configured for one converter to process work for the other. The resulting invalid JSON error left sibling work alive and eventually hung the suite.
The previous API made this easy to do because every test had to independently reconstruct client helpers while using a different factory for its Worker. Binding both operations to one case-scoped helper makes the correct configuration the natural path, gives each converter its own AVA result, and prevents a failed variant from stranding hidden sibling work.
Checklist
Part of Run integration tests against cloud features#851. Stacked on Run Cloud-eligible integration tests by filename #2281.
How was this tested:
child-workflow-termination.git diff --checkpass.ActivityExecutionStatus.PAUSEDproto/type errors.Any docs updates needed?
No. This changes internal test infrastructure only.