Add activity cancels from nexus#1160
Open
Sushisource wants to merge 8 commits into
Open
Conversation
rkannan82
reviewed
Apr 27, 2026
| task_token: Vec<u8>, | ||
| commands: Vec<WorkerCommand>, | ||
| ) -> PollNexusTaskQueueResponse { | ||
| let exec_req = ExecuteCommandsRequest { commands }; |
There was a problem hiding this comment.
Please incorporate the following changes:
- Set task_kind to worker_commands. Add new task queue kind to send worker commands api#763
- Guard new code (creating nexus queue, polling, processing) with worker_commands capability: Add worker_commands namespace capability api#771
rkannan82
reviewed
Apr 30, 2026
| } | ||
| } | ||
| } | ||
| pub mod nexusservices { |
There was a problem hiding this comment.
Does the nexus worker send heartbeat? If it does, then I need to find a way to exclude this from the ListWorkers result.
Member
Author
There was a problem hiding this comment.
~Good question. It shouldn't, if it does I'll make sure it doesn't. ~
Changed my mind. We are already making sure it gets excluded from metrics (since we saw it show up and had that whole discussion re: Nexus usage), and being able to diagnose possible issues with it (getting overloaded, not enough slots, whatever) is useful. Also being dealt with here: temporalio/cli#1019
Sushisource
force-pushed
the
add-activity-cancels-from-nexus
branch
from
05bb5c8 to
322f2a4
Compare
Sushisource
force-pushed
the
add-activity-cancels-from-nexus
branch
from
322f2a4 to
4f0e626
Compare
Sushisource
force-pushed
the
add-activity-cancels-from-nexus
branch
from
4f0e626 to
8bc16e3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creates a worker which polls on the appropriately-named worker commands nexus task queue, and handles and activity cancellations sent down it.
The worker is not started unless the server supports this capability.
Warning
Still waiting on server impl for integ test to pass