Use LangSmith runtime override API instead of monkey-patching aio_to_thread#1477
Open
Use LangSmith runtime override API instead of monkey-patching aio_to_thread#1477
Conversation
xumaple
force-pushed
the
maplexu/langsmith-runtime-override
branch
3 times, most recently
from
76167ff to
acfd0d1
Compare
brianstrauch
reviewed
May 6, 2026
| _aio_to_thread_patched = True | ||
| Safe to call multiple times; the override is only installed once. | ||
| """ | ||
| global _aio_to_thread_override_installed # noqa: PLW0603 |
Contributor
There was a problem hiding this comment.
Any way to avoid a global variable? Could this variable live in the interceptor? I'm guessing probably not since we might want to support multiple instances of the plugin running at the same time?
Contributor
Author
There was a problem hiding this comment.
correct, user could have multiple workers each who have different instances of this plugin installed. so I think it does have to be global.
brianstrauch
approved these changes
May 8, 2026
…ing aio_to_thread LangSmith 0.7.34 added `set_runtime_overrides(aio_to_thread=...)` which provides a supported hook for frameworks with non-standard event loops. This replaces the process-wide monkey-patch of `langsmith._internal._aiter.aio_to_thread` with a call to the official API, making the integration less fragile against LangSmith internal refactors. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
xumaple
force-pushed
the
maplexu/langsmith-runtime-override
branch
from
acfd0d1 to
aa93011
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
langsmith._internal._aiter.aio_to_threadwith LangSmith's officialset_runtime_overrides(aio_to_thread=...)API (added in langsmith 0.7.34)>=0.7.0to>=0.7.34The monkey-patch was fragile against LangSmith internal refactors. The new API is a supported hook for frameworks with non-standard event loops that don't implement
run_in_executor.