Skip to content

Emit client-observed benchmark runner metrics - #32

Merged
robholland merged 1 commit into
mainfrom
robholland/client-invocation-metrics
Sep 25, 2026
Merged

robholland merged 1 commit into
mainfrom
robholland/client-invocation-metrics

Conversation

@robholland

@robholland robholland commented Sep 25, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Emit client-observed benchmark_runner_invocations_{started,completed,failed}_total and benchmark_runner_invocation_duration_seconds{outcome} from the Temporal load runner.
  • Register them on the existing Prometheus endpoint alongside SDK metrics; no new scrape target is needed.
  • Buckets are dense from 5 ms to 60 s and extend to 10 minutes for slower workloads.
  • Count completion and successful latency only when the runner waited and observed workflow completion; a successful -w=false submission is only a start.

@robholland
robholland marked this pull request as ready for review September 25, 2026 13:28
@robholland
robholland requested a review from a team as a code owner September 25, 2026 13:28
@robholland
robholland requested review from jordansinger27 and removed request for a team September 25, 2026 13:28
@robholland
robholland force-pushed the robholland/client-invocation-metrics branch from 41628fe to 8253a3c Compare September 25, 2026 13:35
@robholland
robholland merged commit d3b6472 into main Sep 25, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant