refactor(checks): move global target merging responsibility to checks #278
+199
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit moves the responsibility of merging global targets with the configured targets to each check. This way the checks can decide how to merge the global targets with the configured targets. Signed-off-by: lvlcn-t <75443136+lvlcn-t@users.noreply.github.com>
lvlcn-t
added
refactoring
This commit uses the target.String() representation in error logs to make the error messages more readable. Signed-off-by: lvlcn-t <75443136+lvlcn-t@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #100
I've also added global target merging for the traceroute check, as we didn't enrich the targets yet.
Changes
This commit moves the responsibility of merging global targets with the configured targets to each check. This way the checks can decide how to merge the global targets with the configured targets.
Signed-off-by: lvlcn-t 75443136+lvlcn-t@users.noreply.github.com
For additional information look at the commits.
Tests done
I've added an additional test case for the traceroute enrichment.
E2E tests succeeded- we have none for thisTODO