Repository navigation
Conversation
Callback primaries trusted the LMS issuers of every peer whose mesh includes the zone, including proxy zones. Proxy zones run no Horizon and own no outbound callback Routes, so their LMS tokens never reach a callback primary. Trust is now limited to non-proxy zones whose mesh includes this zone. Also record the callback gateway Consumer in status.callbackConsumer so every owned child is referenced from the EventConfig status. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Callback route trust
gatewayis added as a consumer only when at least one such zone exists.Callback Consumer status
status.callbackConsumerfield on EventConfig (CRD regenerated).Why
Callback primaries trusted the LMS issuer of every peer whose mesh includes the zone, including proxy zones. Proxy zones run no Horizon and own no outbound callback Routes. Every advertised callback URL points at a local backend's gateway, so a proxy zone's LMS token never reaches a callback primary. Trusting those issuers only widened the set of accepted tokens.
In the playground, the issuers of the proxy zones space, canis and hu-it-onprem (all targeting aws) drop out of the callback routes.
The Consumer status reference fixes a
08-child-refs-in-statusfinding from the code-auditor: the Consumer was the only owned child not referenced in status.Reviewer notes
.agents/auditignoregains one entry for a confirmed false positive. The issuer list is sorted and deduplicated inOptions.applySecuritybefore it's stored on the Route.docs/docs/architecture/event.mdx.Tests
callback_routes_test.go:gatewayconsumer.callback_lifecycle_test.gonow checksstatus.callbackConsumer, including after the client ID is replaced.make testandmake lintpass inevent/. The code-auditor (staged scope) reports no findings at or above HIGH.