Skip to content

refactor(event): rename callback proxy query param from "callback" to "url" - #864

Merged
ron96g merged 1 commit into
mainfrom
agents/rename-callback-to-url-query-param
Nov 17, 2026
Merged

ron96g merged 1 commit into
mainfrom
agents/rename-callback-to-url-query-param

Conversation

@ron96g

@ron96g ron96g commented Nov 16, 2026

Copy link
Copy Markdown
Member

Summary

Renames the query parameter used to pass a subscriber's real callback target through the gateway callback Route from callback to url.

  • event: CallbackURLQueryParam is now "url". The callback Route's DynamicUpstream.QueryParameter and the rewritten subscription callback URL (<gateway-callback-url>?url=<subscriber-url>) both use it.
  • spectre: CallbackQueryParam is renamed to "url" as well. Spectre builds callback URLs against the event-owned callback Routes (EventConfig.Status.CallbackURL / ProxyCallbackURLs), so the two values must match.
  • docs: docs/docs/architecture/event.mdx examples now show ?url=U.

Rollout notes

  • Existing subscriptions keep their stored ?callback= URLs until they are reconciled again. Until then, the gateway can't resolve their upstream.
  • event and spectre must be deployed together.

Testing

  • make test passes in event and spectre.
  • code-auditor (staged scope): clean, no findings.

… "url"

The gateway callback Route's DynamicUpstream now reads the subscriber's
target from the "url" query parameter. Spectre builds callback URLs against
the same event-owned Routes, so its CallbackQueryParam is renamed too to
keep delivery working.

Existing subscriptions keep their "?callback=" URLs until re-reconciled;
event and spectre must be deployed together.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@ron96g
ron96g merged commit 46847e6 into main Nov 17, 2026
40 checks passed
@ron96g
ron96g deleted the agents/rename-callback-to-url-query-param branch November 17, 2026 09:43
ron96g added a commit that referenced this pull request Nov 18, 2026
Resolve conflicts with #864 (callback query param renamed to "url") by keeping the query-encoded subscriber URL under the new "url" parameter.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants