Repository navigation
refactor(event): rename callback proxy query param from "callback" to "url" - #864
Merged
Merged
Conversation
… "url" The gateway callback Route's DynamicUpstream now reads the subscriber's target from the "url" query parameter. Spectre builds callback URLs against the same event-owned Routes, so its CallbackQueryParam is renamed too to keep delivery working. Existing subscriptions keep their "?callback=" URLs until re-reconciled; event and spectre must be deployed together. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
lukas016
approved these changes
Nov 16, 2026
ron96g
added a commit
that referenced
this pull request
Nov 18, 2026
Resolve conflicts with #864 (callback query param renamed to "url") by keeping the query-encoded subscriber URL under the new "url" parameter. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Renames the query parameter used to pass a subscriber's real callback target through the gateway callback Route from
callbacktourl.CallbackURLQueryParamis now"url". The callback Route'sDynamicUpstream.QueryParameterand the rewritten subscription callback URL (<gateway-callback-url>?url=<subscriber-url>) both use it.CallbackQueryParamis renamed to"url"as well. Spectre builds callback URLs against the event-owned callback Routes (EventConfig.Status.CallbackURL/ProxyCallbackURLs), so the two values must match.docs/docs/architecture/event.mdxexamples now show?url=U.Rollout notes
?callback=URLs until they are reconciled again. Until then, the gateway can't resolve their upstream.Testing
make testpasses ineventandspectre.