Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues block the bounded Conjur read-retry change.
No open issues 🎉
What changed in this PR
Adds bounded retries to Secret Manager’s Conjur read path to handle transient failures without adding retries to writes or policy changes.
Changes:
- Retries HTTP 408, HTTP 429, and transient network errors for up to three attempts with exponential backoff and jitter; excludes HTTP 5xx responses.
- Wraps the production read client while preserving per-attempt metrics.
- Adds retry tests and documents the behavior.
| File | Description |
|---|---|
secret-manager/pkg/backend/conjur/retry.go |
Implements read retries, backoff, and error classification. |
secret-manager/pkg/backend/conjur/retry_test.go |
Tests retry limits, delays, error classification, and mutation passthrough. |
secret-manager/cmd/server/server.go |
Enables retries around the instrumented Conjur read client. |
docs/docs/architecture/secret-manager.mdx |
Documents retry limits and exclusions. |
Review effort: Balanced
Retry HTTP 408, 429, and transient network failures with bounded exponential backoff and jitter. Leave writes, policy changes, and HTTP 5xx responses unretried.
lukas016
force-pushed
the
feat-lk-conjur-retry
branch
from
November 18, 2026 11:11
f15b9c0 to
448c47e
Compare
ron96g
approved these changes
Nov 20, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Retry HTTP 408, 429, and transient network failures with bounded exponential backoff and jitter. Leave writes, policy changes, and HTTP 5xx responses unretried.