Skip to content

feat(secret-manager): retry transient Conjur read failures - #861

Open
lukas016 wants to merge 2 commits into
mainfrom
feat-lk-conjur-retry
Open

lukas016 wants to merge 2 commits into
mainfrom
feat-lk-conjur-retry

Conversation

@lukas016

Copy link
Copy Markdown
Contributor

Retry HTTP 408, 429, and transient network failures with bounded exponential backoff and jitter. Leave writes, policy changes, and HTTP 5xx responses unretried.

Copilot AI balanced review requested due to automatic review settings November 16, 2026 08:47
@lukas016 lukas016 self-assigned this Nov 16, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues block the bounded Conjur read-retry change.

No open issues 🎉

What changed in this PR

Adds bounded retries to Secret Manager’s Conjur read path to handle transient failures without adding retries to writes or policy changes.

Changes:

  • Retries HTTP 408, HTTP 429, and transient network errors for up to three attempts with exponential backoff and jitter; excludes HTTP 5xx responses.
  • Wraps the production read client while preserving per-attempt metrics.
  • Adds retry tests and documents the behavior.
File Description
secret-manager/​pkg/​backend/​conjur/​retry.go Implements read retries, backoff, and error classification.
secret-manager/​pkg/​backend/​conjur/​retry_test.go Tests retry limits, delays, error classification, and mutation passthrough.
secret-manager/​cmd/​server/​server.go Enables retries around the instrumented Conjur read client.
docs/​docs/​architecture/​secret-manager.mdx Documents retry limits and exclusions.

Review effort: Balanced

Retry HTTP 408, 429, and transient network failures with bounded exponential backoff and jitter.
Leave writes, policy changes, and HTTP 5xx responses unretried.
@lukas016
lukas016 force-pushed the feat-lk-conjur-retry branch from f15b9c0 to 448c47e Compare November 18, 2026 11:11

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants