Repository navigation
docs(operator-guide): record client features we don't enable - #665
Merged
Merged
Conversation
Move the guidance from #510 into the operator guide: never enable the CBOR client gates in a component that talks to an authorization or token-authentication webhook, and do not force or rely on WatchList API streaming. Also warn against the matching KUBE_FEATURE_* overrides. Closes #510 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: MaxRink <maximilian.rink@telekom.de>
Contributor
Output DeltaNo output differences were detected for this PR.
The compare job downloads artifacts only; it does not checkout or execute pull-request code. |
Contributor
📊 Output Delta ReportNo output differences were detected for this PR. No full diff content was generated for this run. |
Contributor
Security scan reportCommit: Security findings are advisory, not merge blockers. Build, test and licensing checks remain blocking. A successful job is not proof of a clean scan; findings and scanner errors are called out below.
See the linked logs for complete findings and any scanner setup failures. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #510
Description
Adds "Client Features We Don't Enable" under Security Considerations in
docs/operator-guide.md, so the reasoning from #510 is found where operators look:ClientsPreferCBOR,ClientsAllowCBOR): never enable. Before 1.35, an apiserver withClientsPreferCBORsent an inappropriateContent-Typeto authorization and token-authentication webhooks (kubernetes#132960). A malformed request to/authorizeturns into an access-control decision.WatchListClient): do not force or rely on it. The gate changed state in almost every release from 1.30 to 1.35, 1.34 removed streaming fromList(), and 1.34 informers ignoredTransformerfuncs.KUBE_FEATURE_*overrides in the operator's environment.One correction to the issue's framing: client-go 0.35+ (we use 0.37.2) turns
WatchListClienton by default for informers, and they fall back to a plain LIST when the server doesn't support streaming. The operator doesn't override that default, so the doc says "don't force or rely on it" for WatchList instead of claiming it is disabled. CBOR gates are alpha and off by default. A grep of the repo finds no use ofClientsPreferCBOR,ClientsAllowCBOR,WatchListClientorKUBE_FEATURE_.I skipped a static test that greps for these gates. AGENTS.md rule 8 asks for no tests that only inspect source or config text.
Type of Change
API Changes
🤖 Generated with Claude Code