Add per-resolution url parameter to Hub Resolver#9459
Closed
ab-ghosh wants to merge 1 commit intotektoncd:mainfrom
Closed
Add per-resolution url parameter to Hub Resolver#9459ab-ghosh wants to merge 1 commit intotektoncd:mainfrom
ab-ghosh wants to merge 1 commit intotektoncd:mainfrom
Conversation
Allow Pipeline authors to override the hub API endpoint per-resolution via a new parameter, instead of relying solely on the cluster-wide ARTIFACT_HUB_API or TEKTON_HUB_API environment variables. - Enables distributed catalog ownership across teams - Supports air-gapped and private deployments - Follows existing patterns (git resolver already has per-resolution url) - Backwards compatible (current behavior unchanged when url not specified) Signed-off-by: ab-ghosh <abghosh@redhat.com>
Collaborator
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Member
Author
|
/kind feature |
Member
Author
|
Closing this PR in favor of a single PR that implements Option C (Option A + Option B combined) as discussed in #9353. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Implements Option A from #9353: adds a
urlparameter to the Hub Resolver that allows Pipeline authors to override the hub API endpoint on a per-resolution basis, instead of relying solely on the cluster-wideARTIFACT_HUB_APIorTEKTON_HUB_APIenvironment variables.urlparam that accepts an absolute HTTP/HTTPS URLARTIFACT_HUB_APIorTEKTON_HUB_APIbased ontypeOption B (multiple default URLs with fallback at the cluster level) will be addressed in a follow-up PR
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes