Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(e2e): resolve instability issues in end-to-end tests #2517

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

l-qing
Copy link
Contributor

@l-qing l-qing commented Jan 16, 2025

Changes

  1. Avoid misunderstanding the pod as being ready
    when it is still deleting or in a 0/1 state.

  2. Avoid misunderstanding the TektonConfig as being ready
    when it is still in the process of being reconcile.

  3. Add the verification of PVC deletion in the undeploy method.
    Avoid the creation of a new hub when the old PVC is still in the
    deleting state, which leads to the failure of starting the new hub.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Release Notes

NONE

@tekton-robot tekton-robot added the release-note-none Denotes a PR that doesnt merit a release note. label Jan 16, 2025
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign puneetpunamiya after the PR has been reviewed.
You can assign the PR to them by writing /assign @puneetpunamiya in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 16, 2025
@tekton-robot
Copy link
Contributor

Hi @l-qing. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 16, 2025
1. Avoid misunderstanding the pod as being ready
   when it is still deleting or in a 0/1 state.

2. Avoid misunderstanding the TektonConfig as being ready
   when it is still in the process of being reconcile.

3. Add the verification of PVC deletion in the undeploy method.
   Avoid the creation of a new hub when the old PVC is still in the
   deleting state, which leads to the failure of starting the new hub.
@l-qing l-qing force-pushed the fix/e2e-instability branch from 33cce82 to 3ba08f3 Compare January 17, 2025 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. release-note-none Denotes a PR that doesnt merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants