fix: avoid panic when reconciling namespace without owner reference #2516
Conversation
tekton-robot
added
the
release-note-none
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Hi @l-qing. Thanks for your PR. I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
tekton-robot
added
needs-ok-to-test
| @@ -43,7 +43,8 @@ func PipelineReady(informer informer.TektonPipelineInformer) (*v1alpha1.TektonPi | |||
| } | |||
| return nil, err | |||
| } | |||
| if ppln.GetStatus() != nil && strings.Contains(ppln.GetStatus().GetCondition(apis.ConditionReady).Message, v1alpha1.UpgradePending) { | |||
| readyCondition := ppln.GetStatus().GetCondition(apis.ConditionReady) | |||
| if readyCondition != nil && strings.Contains(readyCondition.Message, v1alpha1.UpgradePending) { | |||
There was a problem hiding this comment.
In my environment, sometimes the Pipeline has not yet been reconciled, resulting in the status being empty. At this point, entering here may trigger a panic.
There was a problem hiding this comment.
@l-qing we need to keep the check ppln.GetStatus() != nil, otherwise it will panic on ppln.GetStatus().GetCondition, and refactor as you suggest ?
| @@ -56,7 +56,7 @@ func ReconcileTargetNamespace(ctx context.Context, labels map[string]string, ann | |||
| if namespace.Name == tektonComponent.GetSpec().GetTargetNamespace() && namespace.DeletionTimestamp == nil { | |||
| _targetNamespace := namespace.DeepCopy() | |||
| targetNamespace = _targetNamespace | |||
| } else { | |||
| } else if len(namespace.GetOwnerReferences()) > 0 { | |||
There was a problem hiding this comment.
I manually created the ns, which resulted in entering here, causing a panic.
I understand that we should not panic under any circumstances.
|
/ok-to-test |
tekton-robot
added
ok-to-test
|
I think, if you create namespace manually it adds owner reference so in which case a target namespace would not have owner reference? |
|
The following is the coverage report on the affected files.
|
Changes
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
make test lintbefore submitting a PRSee the contribution guide for more details.
Release Notes