adding python sdk azure by arunvel1988 · Pull Request #1323 · tektoncd/catalog

arunvel1988 · 2025-03-26T05:52:51Z

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

Follows the authoring recommendations
Includes docs (if user facing)
Includes tests (for new tasks or changed functionality)
- See the end-to-end testing documentation for guidance and CI details.
Meets the Tekton contributor standards (including functionality, content, code)
Commit messages follow commit message best practices
Has a kind label. You can add one by adding a comment on this PR that
contains /kind <type>. Valid types are bug, cleanup, design, documentation,
feature, flake, misc, question, tep
Complies with Catalog Organization TEP, see example. Note An issue has been filed to automate this validation
- File path follows <kind>/<name>/<version>/name.yaml
- Has README.md at <kind>/<name>/<version>/README.md
- Has mandatory metadata.labels - app.kubernetes.io/version the same as the <version> of the resource
- Has mandatory metadata.annotations tekton.dev/pipelines.minVersion
- mandatory spec.description follows the convention
```
  ```
  
    spec:
      description: >-
        one line summary of the resource
  
        Paragraph(s) to describe the resource.
  ```
```

See the contribution guide for more details.

tekton-robot · 2025-03-26T05:52:54Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign vinamra28 after the PR has been reviewed.
You can assign the PR to them by writing /assign @vinamra28 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

tekton-robot · 2025-03-26T05:53:00Z

Hi @arunvel1988. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

arunvel1988 · 2025-03-26T06:00:22Z

@vinamra28 :)

arunvel1988 · 2025-04-01T10:21:34Z

@vdemeester @vinamra28 kindly review

vinamra28

/ok-to-test

vinamra28 · 2025-04-01T10:36:56Z

task/python-sdk-azure/0.1/README.md

can we please format this MD file with proper headings?

yes will do it ..

vinamra28 · 2025-04-01T10:38:23Z

task/python-sdk-azure/0.1/python-sdk-azure.yaml

+apiVersion: tekton.dev/v1
+kind: Task
+metadata:
+  name: python-azure-sdk


I am trying to think, can we make it a common task which can work with different cloud providers? Having this just for azure means that we are going to have n more tasks for aws, gcp, etc

according to me whole purpose of task is to make it small and concise for a particular step .. hence it will be very cumbersome to make one task for all .. better to keep it isolated

vinamra28 · 2025-04-01T10:39:28Z

task/python-sdk-azure/0.1/python-sdk-azure.yaml

+    app.kubernetes.io/version: "0.1"
+  annotations:
+    tekton.dev/pipelines.minVersion: "0.54.0"
+    tekton.dev/categories: sdk


I doubt that the category: sdk exists. https://github.com/tektoncd/hub/blob/main/config.yaml#L15 are the available categories.

vinamra28 · 2025-04-01T10:40:44Z

task/python-sdk-azure/0.1/python-sdk-azure.yaml

+        name: python-script-configmap
+  steps:
+    - name: run-python-script
+      image: docker.io/library/python:3.9.19-alpine3.20@sha256:45cc18540209d878c2b24080cf8f64fc37603721b67d0ecc508799e2f9a9b21d


should we make this image as a parameter. I can see that image used here is 3.9.19 which is old as the latest python version is 3.13

yes will do it

@vinamra28 done can you check

vinamra28 · 2025-04-06T03:32:57Z

task/python-sdk-azure/0.1/python-sdk-azure.yaml

+    app.kubernetes.io/version: "0.1"
+  annotations:
+    tekton.dev/pipelines.minVersion: "0.54.0"
+    tekton.dev/categories: cloud


@piyush-garg @PuneetPunamiya is hub case sensitive while parsing the category? Cloud vs cloud, former one is what is defined in hub and later one is defined here.

vinamra28 · 2025-04-06T03:38:48Z

task/python-sdk-azure/0.1/README.md

+**Tekton Task for Running Python Scripts with Azure SDK**
+
+This Tekton Task enables execution of Python scripts that utilize the Azure SDK to interact with Azure services. The Task is designed to securely authenticate using Azure credentials and execute the script from a ConfigMap without embedding the script directly in the pipeline.
+
+
+**Features**


hi @arunvel1988, while having the README in the current state is fine, will it be possible for you to use proper markdown headings? You can probably refer a sample readme - https://raw.githubusercontent.com/tektoncd/catalog/refs/heads/main/task/anchore-cli/0.1/README.md

@vinamra28 done

vinamra28 · 2025-04-06T04:49:53Z

@arunvel1988 can you please squash the commits as well?

arunvel1988 · 2025-04-06T05:15:00Z

@vinamra28 done squashing .. can you please check

vinamra28 · 2025-04-08T06:43:38Z

@arunvel1988, I can still see 6 commits 😓

adding python sdk azure

b54598e

tekton-robot requested review from vdemeester and vinamra28 March 26, 2025 05:52

tekton-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 26, 2025

tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 26, 2025

vinamra28 reviewed Apr 1, 2025

View reviewed changes

tekton-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 1, 2025

arunvel1988 and others added 3 commits April 3, 2025 20:05

adding python sdk azure

1e3e7ca

Update README.md

b5d8bed

Update README.md

7eed5d5

vinamra28 reviewed Apr 6, 2025

View reviewed changes

arunvel1988 added 2 commits April 6, 2025 04:26

Update README.md

4de42fe

Update README.md

ed7711e

Merge branch 'tektoncd:main' into main

90a037e

arunvel1988 closed this by deleting the head repository Apr 16, 2025

Conversation

arunvel1988 commented Mar 26, 2025

Changes

Submitter Checklist

Uh oh!

tekton-robot commented Mar 26, 2025

Uh oh!

tekton-robot commented Mar 26, 2025

Uh oh!

arunvel1988 commented Mar 26, 2025

Uh oh!

arunvel1988 commented Apr 1, 2025

Uh oh!

vinamra28 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vinamra28 commented Apr 6, 2025

Uh oh!

arunvel1988 commented Apr 6, 2025

Uh oh!

vinamra28 commented Apr 8, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Comments