Skip to content

Add more sound options for chat #2277 #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: community
Choose a base branch
from

Conversation

teeworlds-mirror
Copy link
Collaborator

@ChillerDragon
Copy link
Member

ChillerDragon commented Apr 25, 2024

@edg-l I gave you access to the branch in case you want to solve the conflict your self. If not I might do it at some point.

@edg-l
Copy link
Collaborator

edg-l commented Apr 25, 2024

you can do it if you want, ill try if i find some time

@jtbx
Copy link
Collaborator

jtbx commented Jun 20, 2024

@ChillerDragon If you want to merge PRs with conflicts without the author's intervention, you can apply it as a patch manually:

curl -Ls https://github.com/teeworlds-community/teeworlds/pull/106.patch | git am -3

After that you can solve any conflicts locally and push to master. Very neat trick for situations like these.

Your local git identity will be set as the "committer" of the change so people can tell you applied/rebased the commit. I don't count this a problem but if you want the author and committer to stay consistent you can use git config --local in the repository to temporarily change your identity.

@ChillerDragon
Copy link
Member

@jtbx a cool I did not know about this neat oneliner. But it is less of a technical problem. This branch is already a copy where I have full write access to. Its just a matter of finding the energy to actually solve the conflict. And also I would prefer the code owner to solve the conflicts. And not get their code broken by my conflict accidents.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants