-
Notifications
You must be signed in to change notification settings - Fork 162
Implement copr repository provider
#4471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
599375a to
3e9b581
Compare
| prepare: | ||
| - summary: enable copr repository | ||
| how: artifact | ||
| stage: prepare |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am a little confused about this stage: prepare, I see it in copr_build.py too. But I do not see it defined in any schema file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right to be confused (at-least for now)! Currently the schema does not have the stage: xxx defined - however I think it will be introduced shortly once the install phase kicks in. So essentially, we will have:
Again this is based on my understanding - @psss WDYT?
| :return: Empty list as no files are downloaded. | ||
| """ | ||
| copr = Copr(copr_plugin='dnf-plugins-core', guest=guest) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cursor seems to think the logger should be passed in here since it's a required argument in the constructor for the Common class in tmt/utils/init.py
When I installed the built tmt package for this PR and took it for a spin, I got the following error that seems to reinforce that:
plan failed.
The exception was caused by 1 earlier exceptions
Cause number 1:
prepare step failed
The exception was caused by 1 earlier exceptions
Cause number 1:
Failed to initialize or use artifact provider 'copr.repository:@teemtee/stable'.
The exception was caused by 1 earlier exceptions
Cause number 1:
Common.__init__() missing 1 required keyword-only argument: 'logger'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed here: b97a8c3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the quick update! The new complaint seems to be:
'Copr' object has no attribute 'copr_plugin'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Therese for testing this out again. Okay, so I have refactored / cleaned the constructor of Copr - b62d365. Need to know how you test this out :)
Resolves #4385
Pull Request Checklist