Skip to content

Conversation

@AthreyVinay
Copy link
Contributor

@AthreyVinay AthreyVinay commented Jan 8, 2026

Resolves #4385

Pull Request Checklist

  • implement the feature
  • extend the test coverage

@AthreyVinay AthreyVinay added this to the 1.65 milestone Jan 8, 2026
@AthreyVinay AthreyVinay self-assigned this Jan 8, 2026
@AthreyVinay AthreyVinay added ci | full test Pull request is ready for the full test execution plugin | artifact Related to the `prepare/artifact` plugin. labels Jan 8, 2026
@github-project-automation github-project-automation bot moved this to backlog in planning Jan 8, 2026
@AthreyVinay AthreyVinay moved this from backlog to review in planning Jan 8, 2026
@AthreyVinay AthreyVinay force-pushed the avinay-implement-copr-repo branch from 599375a to 3e9b581 Compare January 8, 2026 23:26
prepare:
- summary: enable copr repository
how: artifact
stage: prepare
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am a little confused about this stage: prepare, I see it in copr_build.py too. But I do not see it defined in any schema file?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right to be confused (at-least for now)! Currently the schema does not have the stage: xxx defined - however I think it will be introduced shortly once the install phase kicks in. So essentially, we will have:

  1. stage: prepare
  2. stage: install

Again this is based on my understanding - @psss WDYT?

:return: Empty list as no files are downloaded.
"""
copr = Copr(copr_plugin='dnf-plugins-core', guest=guest)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor seems to think the logger should be passed in here since it's a required argument in the constructor for the Common class in tmt/utils/init.py

When I installed the built tmt package for this PR and took it for a spin, I got the following error that seems to reinforce that:

plan failed.

The exception was caused by 1 earlier exceptions

Cause number 1:

    prepare step failed

    The exception was caused by 1 earlier exceptions

    Cause number 1:

        Failed to initialize or use artifact provider 'copr.repository:@teemtee/stable'.

        The exception was caused by 1 earlier exceptions

        Cause number 1:

            Common.__init__() missing 1 required keyword-only argument: 'logger'

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed here: b97a8c3

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick update! The new complaint seems to be:

'Copr' object has no attribute 'copr_plugin'

Copy link
Contributor Author

@AthreyVinay AthreyVinay Jan 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Therese for testing this out again. Okay, so I have refactored / cleaned the constructor of Copr - b62d365. Need to know how you test this out :)

@thrix thrix requested a review from tcornell-bus January 13, 2026 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci | full test Pull request is ready for the full test execution plugin | artifact Related to the `prepare/artifact` plugin.

Projects

Status: review

Development

Successfully merging this pull request may close these issues.

Prepare artifacts repository from copr repository

3 participants