Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move connecting state logic into proper methods #1661

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

arthurschreiber
Copy link
Collaborator

This moves the logic that lived in the connection state machine into proper methods.

Copy link

codecov bot commented Sep 11, 2024

Codecov Report

Attention: Patch coverage is 61.72840% with 62 lines in your changes missing coverage. Please review.

Project coverage is 85.47%. Comparing base (aa0f183) to head (7ba5ddb).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/connection.ts 61.72% 61 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1661   +/-   ##
=======================================
  Coverage   85.46%   85.47%           
=======================================
  Files          90       90           
  Lines        4857     4859    +2     
  Branches      924      924           
=======================================
+ Hits         4151     4153    +2     
  Misses        702      702           
  Partials        4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arthurschreiber arthurschreiber merged commit e1b37fb into master Sep 11, 2024
26 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant