Add Docker Compose to the course! #147
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
LUS24
reviewed
Apr 4, 2024
docs/docs/11_deploy_to_render/06_run_everything_docker_compose/README.md
Outdated
Show resolved
Hide resolved
LUS24
reviewed
Apr 4, 2024
docs/docs/12_task_queues_emails/01_send_emails_python_mailgun/end/migrations/env.py
Outdated
Show resolved
Hide resolved
LUS24
reviewed
Apr 4, 2024
docs/docs/12_task_queues_emails/01_send_emails_python_mailgun/start/migrations/env.py
Outdated
Show resolved
Hide resolved
LUS24
reviewed
Apr 4, 2024
docs/docs/12_task_queues_emails/02_send_email_user_registration/end/migrations/env.py
Outdated
Show resolved
Hide resolved
LUS24
reviewed
Apr 4, 2024
docs/docs/12_task_queues_emails/02_send_email_user_registration/start/migrations/env.py
Outdated
Show resolved
Hide resolved
LUS24
reviewed
Apr 4, 2024
docs/docs/12_task_queues_emails/04_populate_rq_task_queue/end/migrations/env.py
Outdated
Show resolved
Hide resolved
LUS24
reviewed
Apr 4, 2024
docs/docs/12_task_queues_emails/05_rq_background_worker/start/migrations/env.py
Outdated
Show resolved
Hide resolved
LUS24
reviewed
Apr 4, 2024
docs/docs/12_task_queues_emails/06_sending_html_emails/start/migrations/env.py
Outdated
Show resolved
Hide resolved
LUS24
reviewed
Apr 4, 2024
docs/docs/12_task_queues_emails/07_deploy_background_worker_render/end/migrations/env.py
Outdated
Show resolved
Hide resolved
LUS24
reviewed
Apr 4, 2024
docs/docs/12_task_queues_emails/07_deploy_background_worker_render/start/migrations/env.py
Outdated
Show resolved
Hide resolved
LUS24
reviewed
Apr 4, 2024
docs/docs/11_deploy_to_render/06_run_everything_docker_compose/end/CONTRIBUTING.md
Outdated
Show resolved
Hide resolved
LUS24
reviewed
Apr 4, 2024
docs/docs/11_deploy_to_render/06_run_everything_docker_compose/start/CONTRIBUTING.md
Outdated
Show resolved
Hide resolved
LUS24
reviewed
Apr 4, 2024
docs/docs/11_deploy_to_render/06_run_everything_docker_compose/start/README.md
Show resolved
Hide resolved
LUS24
reviewed
Apr 4, 2024
docs/docs/11_deploy_to_render/06_run_everything_docker_compose/end/requirements.txt
Show resolved
Hide resolved
LUS24
reviewed
Apr 4, 2024
docs/docs/11_deploy_to_render/06_run_everything_docker_compose/start/requirements.txt
Show resolved
Hide resolved
It's no longer required and indeed gives an error. Removed `compare_type` from lecture body and also from section 12 code.
One in Docker section to run the app on its own, and one when we introduce a PostgreSQL database to spin up both the app and db.
Co-authored-by: Leonardo U Spairani <[email protected]>
jslvtr
force-pushed
the
jose/cou-323-add-information-on-docker-compose-to-the-course
branch
from
fe0d6d6 to
31a6e8d
Compare
LUS24
previously approved these changes
Apr 4, 2024
Also removed `CONTRIBUTING.md` file as it isn't necessary in the code files.
jslvtr
force-pushed
the
jose/cou-323-add-information-on-docker-compose-to-the-course
branch
from
31a6e8d to
ad4f496
Compare
LUS24
approved these changes
Apr 4, 2024
jslvtr
deleted the
jose/cou-323-add-information-on-docker-compose-to-the-course
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New content
Changes
compare_typefrom all parts of the course since it is no longer required for Alembic to notice type changes between columns (e.g. length of text columns)