chore: bypass post survey handler if enabled in Lambda [CHI-3218] #757
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
stephenhand
reviewed
May 1, 2025
| @@ -78,7 +78,8 @@ const isTriggerPostSurvey = ( | |||
| * Checks the event type to determine if the listener should handle the event or not. | |||
| * If it returns true, the taskrouter will invoke this listener. | |||
| */ | |||
| export const shouldHandle = (event: EventFields) => eventTypes.includes(event.EventType); | |||
| export const shouldHandle = () => false; | |||
There was a problem hiding this comment.
Will this not mean this code will never run, whether the flag is enabled or not?
There was a problem hiding this comment.
Ups, thanks for the catch, just reverted that.
stephenhand
approved these changes
May 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related to techmatters/flex-plugins#2929.
Description
Checklist
Other Related Issues
None
Verification steps
AFTER YOU MERGE
You are responsible for ensuring the above steps are completed. If you move a ticket into QA without advising what version to test, the QA team will assume the latest tag has the changes. If it does not, the following confusion is on you! :-P