-
Notifications
You must be signed in to change notification settings - Fork 3
CHI-3500: Make address values for USCH into filterable paths #950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
a41eec4
Make address values for USCH into filterable paths
stephenhand 8b6abef
Update list attributes endpoints to take a filter, to have key as a p…
stephenhand b6a74a6
Licence Header
stephenhand 0c33d63
Update reference list endpoint to accept encoded or not encoded list …
stephenhand 287b65b
Fix backwards compat for list attributes endpoint
stephenhand 8f8860e
Update resources-domain/lambdas/s3-importer/src/uschMappings.ts
stephenhand 7f1cb59
Merge branch 'master' into CHI-3500-usch_location_paths
stephenhand b733370
fix replaceAll call
stephenhand 92d372f
Add extra mappings to populate dropdowns from correct data source
stephenhand dd7496f
Fix coverage section naming
stephenhand 83d9406
Remove logs
stephenhand a273bb8
Update types
stephenhand 15841df
Look up state names for coverage info
stephenhand 57a9a88
Fixed coverage importing
stephenhand e10f6e6
Allow descendants of keys to be included in list-string-attributes. T…
stephenhand c1c639e
Fix TS
stephenhand 6a78def
Fix mappings to work with filters
stephenhand 9916608
Add name to coverage for US / Canada
stephenhand File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we document what's this doing? Is
paramsnow a list or how is this working? 🤔There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes /* returns a list, which is documented in Express, I'm not sure we should document standard API behaviour