Skip to content

Add no-argument form of RFI #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

interfect
Copy link

No description provided.

@paultech
Copy link

paultech commented Oct 7, 2016

I feel like the emulator/assembler should be strict in requiring all operations require a argument. The specification does outline the use of a operand on all instructions.

@Yamakaky
Copy link

Yamakaky commented Oct 7, 2016

I agree

@interfect
Copy link
Author

I think the assembler should be liberal in what it accepts. The operand of
RFI is never sued, so while specifying one sometimes could be useful for
optimizations (RFI POP), having to specify something always is just going
to waste users' time and make code worse. Having an "RFI 0" in code is just
confusing, and getting an error because you didn't specify an argument
that's always discarded is super annoying. The assembler should provide a
sane default.

On Thu, Oct 6, 2016 at 8:21 PM, Yamakaky [email protected] wrote:

I agree


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#12 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAt5tmtmytK-nTfpX7tML1SK2QYmUPqbks5qxbq3gaJpZM4JDy4t
.

@eva-knight
Copy link

I think that given the spec states it takes an argument, it'd be better to leave as is. If you're annoyed by the RFI 0 and whatnot in your code, you could just make a macro for RFI 0, eg "macro FOO=RFI 0" or something. I think adding special cases into the code like this will end up too messy (hence why stuff like "asciiz" and "reserve" are implemented as default macros).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants