Packaging with pyproject.toml #29
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My take on how to package DENSS using pyproject.toml
There was some refactoring needed: All executable python files were moved to a package
denssand their code moved to a functionmain(). This allowed creation of proper entrypoints. Resulting CLI commands are missing the*.pysuffix.ScipyandNumpynow installs automatically.Matplotlibwas kept as "optional", however, personally I would put in the full requirements.A citation file was added.
In this stage,
superdenssandbest_enantiomers.shdo not install. Dirty fix would be wrapping them usingsubprocessfor example, ideally they should be rewritten to Python as then it would make DENSS platform agnostic 100% (it mostly runs on Windows already).