Add plucks functionality for followers of an object #102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Hmm, it looks like the issue is with minitest plugin, but that seems to work fine on my end. |
…orts plugin. This addition addresses that bug without changing the versions listed in the Gemfile or gemspec.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds functionality simulating the Activerecord method
pluck. Likepluck, the method can accept multiple column names.The method currently returns data for all followers of the object, regardless of the scope. Trying to allow options on scoping causes a problem with eager loading as this is a polymorphic association. I chose to abandon that route as I did not want to change a fundamental feature of the gem as it is now. If anyone knows of a way to allow options on scoping without running into eager loading efforts, please let me know of add your own commits to this branch.