Skip to content

Commit

Permalink
WebDriver: Add a --use-default-settings option
Browse files Browse the repository at this point in the history
This launches the browser with its default settings.
  • Loading branch information
tcl3 committed Jul 10, 2024
1 parent 11d91ab commit fa93c61
Showing 1 changed file with 8 additions and 2 deletions.
10 changes: 8 additions & 2 deletions Ladybird/WebDriver/main.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ static ErrorOr<pid_t> launch_process(StringView application, ReadonlySpan<char c
return result;
}

static ErrorOr<pid_t> launch_browser(ByteString const& socket_path, bool use_qt_networking)
static ErrorOr<pid_t> launch_browser(ByteString const& socket_path, bool use_qt_networking, bool use_default_settings)
{
auto arguments = Vector {
"--webdriver-content-path",
Expand All @@ -50,6 +50,9 @@ static ErrorOr<pid_t> launch_browser(ByteString const& socket_path, bool use_qt_
if (use_qt_networking)
arguments.append("--enable-qt-networking");

if (use_default_settings)
arguments.append("--use-default-settings");

arguments.append("about:blank");

return launch_process("Ladybird"sv, arguments.span());
Expand All @@ -75,12 +78,15 @@ ErrorOr<int> serenity_main(Main::Arguments arguments)
auto listen_address = "0.0.0.0"sv;
int port = 8000;
bool enable_qt_networking = false;
bool use_default_settings = false;

Core::ArgsParser args_parser;
args_parser.add_option(listen_address, "IP address to listen on", "listen-address", 'l', "listen_address");
args_parser.add_option(port, "Port to listen on", "port", 'p', "port");
args_parser.add_option(certificates, "Path to a certificate file", "certificate", 'C', "certificate");
args_parser.add_option(enable_qt_networking, "Launch browser with Qt networking enabled", "enable-qt-networking");
args_parser.add_option(use_default_settings, "Launch browser with default settings", "use-default-settings");

args_parser.parse(arguments);

auto ipv4_address = IPv4Address::from_string(listen_address);
Expand Down Expand Up @@ -117,7 +123,7 @@ ErrorOr<int> serenity_main(Main::Arguments arguments)
}

auto launch_browser_callback = [&](ByteString const& socket_path) {
return launch_browser(socket_path, enable_qt_networking);
return launch_browser(socket_path, enable_qt_networking, use_default_settings);
};

auto maybe_client = WebDriver::Client::try_create(maybe_buffered_socket.release_value(), { move(launch_browser_callback), launch_headless_browser }, server);
Expand Down

0 comments on commit fa93c61

Please sign in to comment.